-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore patterns are applied to the absolute path instead of relative to the working directory #441
Comments
Failing test case: In
It should fail. This never surfaced since the ABSOLUTE CWD was always added in all test cases in front of the |
Facing the same issue. Just by looking at the code I'd guess the culprit is at Either:
fast-glob/src/providers/filters/entry.ts Lines 69 to 77 in 1e520c1
@mrmlnc What do you think? I'd be happy to try and submit a PR for this. |
PR: #445 |
Whoop. Nice. Let'S get that released. Thanks for the hard work <3 |
Environment
Actual behavior
Expected behavior
Steps to reproduce
~/something/
index.test.js
in thereCode sample
index.ts:
The problem seems to be that the parameter
absolute
which is documented as an output control parameter (https://www.npmjs.com/package/fast-glob#output-control) is getting in the way of filtering.I have not found the correct place in the code yet, but I figure that paths are RESOLVED first and then FILTERED, instead of FILTERED relatively to
cwd
first and then RESOLVED to their absolute counterparts.I hope what I am getting to is clear. Maybe this is intentional behaviour, but i found no documented evidence of that anywhere.
The text was updated successfully, but these errors were encountered: