Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories end with / with markDirectories: false and // with markDirectories: true #46

Closed
pvdlg opened this issue Jan 30, 2018 · 2 comments
Assignees

Comments

@pvdlg
Copy link

pvdlg commented Jan 30, 2018

With the following directory tree:

+-- test/
|   +-- dir
|       +-- file.js
fg.sync('test/**', {onlyFiles: false, markDirectories: false});

// Result => ['test/dir/', 'test/dir/file.js']
// Should be => ['test/dir', 'test/dir/file.js']
fg.sync('test/**', {onlyFiles: false, markDirectories: true});

// Result => ['test/dir//', 'test/dir/file.js']
// Should be => ['test/dir/', 'test/dir/file.js']
@mrmlnc
Copy link
Owner

mrmlnc commented Jan 31, 2018

Thanks for feedback! 🌮

I really appreciate it! Fixed by #43.

@mrmlnc mrmlnc closed this as completed Jan 31, 2018
@pvdlg
Copy link
Author

pvdlg commented Jan 31, 2018

Thanks so much!

I trying to migrate globby from node-glob to fast-glob to benefit from the perf improvements.
So I'm doing quite some tests :)

fast-glob is awesome! The perf are really good, and the node ecosystem really need a well maintained glob solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants