fix: Fix build when using use_frameworks
#379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…ble folly config
|
Bravo, Let's go.... 🚀🚀🚀🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, Folly seems to spazz out when building the iOS app with
use_frameworks/ENV['USE_FRAMEWORKS']enabled.Frameworks are a relict of the past anyways and are not really recommended to be used because they're dynamically linked instead of statically compiled modules, which is what Swift supports now.
But Firebase still seems to use Frameworks and for some reason STILL haven't migrated away from it.
People complained to me that Nitro doesn't build with Firebase, instead of telling Firebase to migrate away from Frameworks.
Anyways.. This now adds support for Frameworks.
For this to work, we have to disable the Folly configuration (
FOLLY_NO_CONFIG) and coroutines, and import the-Swift.hheader using the fully qualified name.I have no idea why Folly seems to fail to build with frameworks, but whatever.
Since this is not really part of Nitro or Nitrogen, users are expected to add this to their
.podspecfiles.This PR is based off of #333 (so huge thanks to the author!), but with a few changes. Also it is formatted properly. And instead of just removing the
NitroLoggerimport (which breaks the build), I exposed NitroLogger as a public header. Also I added deps on JSI and CallInvoker.