feat: Remove hybridContext
and memorySize
from Swift HybridObjects (make them optional)
#420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift Hybrid Objects we previously always required the user to fill in
hybridContext
andmemorySize
because Swift protocols don't allow default values, and there's no abstract class in Swift.I found a solution with a
typealias
tho, and now we can pre-fillhybridContext
andmemorySize
!For library users, this now means you can remove those fields from your Swift class;
If you have a custom type that is heavy on memory, it is still recommended to override
memorySize
;THIS IS A BREAKING CHANGE