feat: Implement Swift errors 🥳 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
renanmav
reviewed
Dec 18, 2024
| ( | ||
| await it(async () => await testObject.funcThatThrowsBeforePromise()) | ||
| ).didThrow( | ||
| `Error: ${testObject.name}.funcThatThrowsBeforePromise(...): This function will only work after sacrificing eight lambs!` |
|
Awesome, very excited to try this out! Just upgrading the library to 0.20.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally implements errors for synchronous Swift functions.
Every Swift function is now wrapped with a
Result<T>type that is eitherT(hasValue()) orstd::exception_ptr(hasError()).This adds a tiny bit of runtime overhead, but at least now we can throw errors that can actually be caught in JS without crashing the app.
I hope in a future version of Swift, Swift errors can actually be caught in C++ so that we can remove this result type wrapping and instead use normal try/catch flows....