Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create HybridView Swift and Kotlin base #494

Merged
merged 46 commits into from
Jan 15, 2025
Merged

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Jan 13, 2025

  • Creates HybridView.swift and HybridView.kt
  • Creates HybridView TS interface that extends HybridObject. This doesnt generate a native interface but instead has a special branch to apply protocol HybridView from above to the Hybrid Objects
  • Improves inheritance / base class lookup so it actually works really solid. This was required for HybridView and might've fixed some bugs in HybridObjects with inheritance.
  • Add the C++ ShadowNode/Props/State/ComponentDescriptor generator (no prop setting yet)
  • Move the System.loadLibrary() into a shared file (NitroImageOnLoad.kt) that can be called instead of a System.loadLibrary by the user. Should improve perf a little bit.

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nitro-docs ⬜️ Skipped (Inspect) Jan 15, 2025 7:13pm

@mrousavy mrousavy force-pushed the feat/generate-hybrid-view branch from 800726f to 71ae446 Compare January 13, 2025 15:15
@mrousavy mrousavy force-pushed the feat/generate-hybrid-view branch from 0631079 to b7d4b37 Compare January 14, 2025 10:42
@mrousavy mrousavy force-pushed the feat/generate-hybrid-view branch from 37b8f77 to 2c19ee7 Compare January 15, 2025 17:57
@mrousavy mrousavy merged commit 3387184 into main Jan 15, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant