fix: Fix NullPointerException in initFrameProcessorPlugin if plugin is not found
#2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vanenshi
changed the title
vanenshi
changed the title
mrousavy
changed the title
NullPointerException in initFrameProcessorPlugin if plugin is not found
|
Hey, thank you for your contribution!! This is perfect, nice catch. I just added two annotations to make this even clearer (with those I would've caught the mistake as bridging Java -> Kotlin requires such annotations, otherwise non-null is assumed) Once the CI goes green we can merge 🚀 |
|
merged! 🚀 |
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
…in is not found (mrousavy#2454) * fix: fix the null exception * Add `Nullable` and `NonNull` annotations --------- Co-authored-by: Marc Rousavy <me@mrousavy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If you call the
VisionCameraProxy.initFrameProcessorPlugin('processor');and the specific processor were not available, the whole program crash with this errorthis fix mark the getPlugin function as nullable
Changes
mark the getPlugin function as nullable
Tested on
Android simulator, and real android device