fix: Fix Frame Processor SIGSEV crash in VisionCameraScheduler::trigger by locking mutex in dispatchAsync
#2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrousavy
changed the title
VisionCameraScheduler::triggger
mrousavy
changed the title
VisionCameraScheduler::trigggerVisionCameraScheduler::trigger by locking mutex in dispatchAsync
|
great work!!! thank you ❤️ |
5 tasks
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
…ger` by locking mutex in `dispatchAsync` (mrousavy#2591) Add missing lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix for the crash on frame processor updates in
VisionCameraSchedulerby making sure thetriggerandschedulefunctions are properly locked with a Mutex.Changes
Add a missing lock.
Tested on
Galaxy S21
Related issues
std::__ndk1::__function::__func<T>::operator(), occurs in the release build only(maybe) #2178