Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add minFps and maxFps props #3074

Merged
merged 7 commits into from
Jul 12, 2024
Merged

feat: Add minFps and maxFps props #3074

merged 7 commits into from
Jul 12, 2024

Conversation

mrousavy
Copy link
Owner

What

Adds minFps and maxFps props which allow you to set a variable FPS range.

When minFps is lower than maxFps, the Camera pipeline can throttle it's FPS rate to expose frames longer for better quality in low-light conditions!

fps will still exist as a short-hand for setting minFps and maxFps to the same value.

Changes

Tested on

Related issues

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 11:11am

@mrousavy mrousavy merged commit 23bfe15 into main Jul 12, 2024
12 of 13 checks passed
@mrousavy mrousavy deleted the feat/fps-mode branch July 12, 2024 11:11
isaaccolson pushed a commit to isaaccolson/deliveries-mobile that referenced this pull request Oct 30, 2024
* feat: Add `minFps` and `maxFps` props

* Implement Android

* Pods

* fix: Fix comparison

* feat: Allow `fps` to be either a number or a tuple

* Update CameraSession+Configuration.swift

* docs: Add docs explaining variable FPS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant