feat: Throw an Error if Frame is already destroyed
#3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
* feat: Throw an error if ObjC `Frame` is invalid * fix: Remove duplicate Frame closed checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously we only checked if
Framewas already destroyed when trying to access it through JS (throughFrameHostObject) - but some people/companies (cc @terrysahaidak / @marblemedia / @canfan / @thomas-coldwell) have custom Frame Processor solutions where they accessFramedirectly (the ObjC/Java class), and callincrementRefCount()/decrementRefCount()there.In there, we didn't really check if the
Frameis still valid, and so we didn't throw any nice errors if it wasn't - apps just crashed with SIGBART.So this PR now changes that and moves all checks to see if a frame is valid inside the actual
Frameimplementation (where it should've belonged in the first place imo).This is safer, and also more efficient on Java since it's one less JNI call per each prop you access. 🎉
Changes
Tested on
Related issues