Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added condition for fetching roles having forward slash(/) in its name #175

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Added condition for fetching roles having forward slash(/) in its name #175

merged 2 commits into from
Nov 19, 2019

Conversation

Shubhammathur22
Copy link
Contributor

@Shubhammathur22 Shubhammathur22 commented Nov 16, 2019 •
edited
Loading

Issue: Terraform giving 404 error while fetching client roles having forward slash(/) in its name.

Resolution: Added Replace string where ever required

Example Resource Name: Test/123

@Shubhammathur22
Copy link
Contributor Author

Hi @mrparkers , Could you please check this PR ?

@Shubhammathur22 Shubhammathur22 mentioned this pull request Nov 18, 2019
Closed
@mrparkers
Copy link
Contributor

Hi @Shubhammathur22, thanks for the PR!

The code itself looks good. Would you mind adding a test case for the change you made?

You can copy/paste this test case and update the roleName variable to include a forward slash, and you should be good to go!

@Shubhammathur22
Copy link
Contributor Author

Sure @mrparkers , I will add the test case for this PR shortly

@Shubhammathur22
Copy link
Contributor Author

@mrparkers , added the test case, please check

mrparkers
mrparkers approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again for the PR!

@mrparkers mrparkers merged commit 6e58fe9 into keycloak:master Nov 19, 2019
@Shubhammathur22
Copy link
Contributor Author

Thanks @mrparkers for managing this very useful provider code. Also, could you please share the version number which would be having the above changes? and when it will be released?

@mrparkers
Copy link
Contributor

My pleasure, I'm glad you find it useful!

CI is in the middle of building and releasing 1.13.1 right now. It should be available in about 10 minutes.

@Shubhammathur22
Copy link
Contributor Author

Great !!! Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shubhammathur22 @mrparkers @shubham-mathur