brute-force-detection-settings + ssl_required + custom-realm-attributes + fix 174 + k8.0.0 #183
Conversation
… + support for custom-realm-attributes + bugfix for keycloak#174
|
The change of behavior of revoke refresh tokens settings should be mentioned in the release notes. |
|
@mrparkers Did you have a chance to look at this PR? Do you have any remarks? |
| //extra attributes of a realm | ||
| Attributes map[string]interface{} `json:"attributes"` | ||
|
|
||
| BrowserSecurityHeaders BrowserSecurityHeaders `json:"browserSecurityHeaders"` |
There was a problem hiding this comment.
Is this a breaking change in Keycloak's API? It looks like we were using _browser_header before - is that going to break this provider's compatibility with older versions of Keycloak?
There was a problem hiding this comment.
The Realm tests stills work if I run on ac test with 'make local' and docker-compose pointing to keycloak version 4.8.3.Final
There 2 ways of setting these parameters, The UI is using the way above
I have no idea why there are 2 ways to do this. If you set both ways at the same time with different values, then setting it directly as a real parameters wins from setting it through the attributes.
Thus this seems to be the safer bet and a more correct way to do it through this method.
tomrutsaert
deleted the
brute_force_detection_requiressl_custom_realm_attributes
branch
support for brute-force-detection-settings
support for ssl_required
support for custom-realm-attributes
bugfix for #174
upgrade to keycloak 8.0.0