Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow empty value for pkce_code_challenge_method #198

Merged
merged 1 commit into from
Jan 16, 2020
Merged

fix: allow empty value for pkce_code_challenge_method #198

merged 1 commit into from
Jan 16, 2020

Conversation

dlechevalier
Copy link
Contributor

Allow an empty value for pkce_code_challenge_method

@dlechevalier dlechevalier mentioned this pull request Jan 15, 2020
Closed
mrparkers
mrparkers approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@mrparkers mrparkers merged commit a06fc1e into keycloak:master Jan 16, 2020
@dlechevalier dlechevalier deleted the fix/PKCE-default-options branch January 17, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlechevalier @mrparkers