Adds option to provide a CA root certificate for x509 validation #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrparkers
approved these changes
Feb 25, 2020
chopshop1
pushed a commit
to ware2go/terraform-provider-keycloak
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current setup utilises staging certificates for our development environment. To prevent the client from x509 errors with respect to invalid root certificates, the new provider parameter allows the inclusion of a root CA certificate chain as a string. The client adds it to the http client if it is defined.
If there's anything that needs more work feel free to let me know, this is the first time I've fiddled with some Go code.