Data source for user and authentication execution #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmasikome
force-pushed
the
feature/add-data-source-user-and-authentication-execution
branch
2 times, most recently
from
fda157d to
27c7da8
Compare
rjmasikome
force-pushed
the
feature/add-data-source-user-and-authentication-execution
branch
from
4fd2210 to
6c86641
Compare
…source-user-and-authentication-execution
mrparkers
suggested changes
Sep 3, 2020
There was a problem hiding this comment.
Apologies for the late review on this.
The only potential issue I'm noticing here is that the schemas for these new data sources don't match the schemas for their equivalent resources. Typically we'd expect these schemas to match unless there is a good reason not to.
Could you update the data source schemas, or help me understand if there was particular reason to omit the other attributes?
|
Thanks for the review. I have updated the requested changes. I thought it doesn't need to be included because it is optional. Let me know if anything else need to be changed. Cheers. |
mrparkers
approved these changes
Sep 13, 2020
|
Hey thanks for the change. LGTM. |
hcl31415
pushed a commit
to hcl31415/terraform-provider-keycloak
that referenced
this pull request
Oct 12, 2020
hcl31415
pushed a commit
to hcl31415/terraform-provider-keycloak
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I didn't see any contribution guidelines, so I will just go ahead and open this PR. This Pull Request will add data source for User and Authentication Execution. Currently we need that for our process.
If there's anything lacking please do let me know.
Cheers,
RJ