Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get authentication flow by alias #486

Merged
merged 9 commits into from
Mar 12, 2021
Merged

Get authentication flow by alias #486

merged 9 commits into from
Mar 12, 2021

Conversation

Zeldhyr
Copy link
Contributor

@Zeldhyr Zeldhyr commented Feb 16, 2021 •
edited
Loading

Closes #466

@Zeldhyr Zeldhyr force-pushed the feature/data_keycloak_authentication_flow branch from eed63cd to bd35c83 Compare February 16, 2021 15:29
@Zeldhyr Zeldhyr force-pushed the feature/data_keycloak_authentication_flow branch from 2e7933c to 2a31da3 Compare February 17, 2021 09:08
@Zeldhyr Zeldhyr marked this pull request as ready for review February 18, 2021 14:51
@AdrienFromToulouse
Copy link
Contributor

👋 @mrparkers do you know why the tests are not triggered?

@mrparkers
Copy link
Contributor

Hey @Zeldhyr and @AdrienFromToulouse, not sure why the tests didn't trigger originally but they triggered after merging the master branch.

Looks like your tests are failing because provider.go needs to be updated to add the new data source.

@Zeldhyr Zeldhyr force-pushed the feature/data_keycloak_authentication_flow branch from 2ae3648 to dcc362c Compare March 1, 2021 09:53
@Zeldhyr Zeldhyr force-pushed the feature/data_keycloak_authentication_flow branch from 3b9fedb to 9d1d590 Compare March 1, 2021 11:22
@Zeldhyr Zeldhyr force-pushed the feature/data_keycloak_authentication_flow branch from 9931ac7 to 464cea2 Compare March 2, 2021 14:50
@Zeldhyr Zeldhyr force-pushed the feature/data_keycloak_authentication_flow branch from 270c2c4 to 1b3f7d2 Compare March 2, 2021 17:07
mrparkers
mrparkers approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the PR!

@mrparkers mrparkers merged commit 2df0fac into keycloak:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DATA] - data keycloak_authentication_flow is missing
3 participants
@Zeldhyr @AdrienFromToulouse @mrparkers