keycloak_saml_identity_provider: support entity_id as required field #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSanetra
force-pushed
the
support-saml-entity-id
branch
from
9eb17d6 to
3f598da
Compare
|
Hey @PSanetra, thanks for the PR. this change looks fine overall, but any of the existing tests that use this resource will need to be updated to use this new attribute. would you be able to do that in order to get the tests passing? thanks! |
PSanetra
force-pushed
the
support-saml-entity-id
branch
from
3f598da to
681a206
Compare
|
@mrparkers I have fixed the tests and adjusted the documentation |
mrparkers
approved these changes
Apr 9, 2021
|
@mrparkers Is there some ETA for a new release with this change or is it possible to get a pre-release? |
|
@PSanetra v3.0.0 has been released today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the required field
entity_idon the resourcekeycloak_saml_identity_provider.Notice: This is a breaking change. I think it is weird that this field is required in the Admin Console but the REST API seems to be ok if the field is missing. I would still make it a required field as using the Admin Console on an SAML identity provider may otherwise result in unexpected behavior.
Fixes #510