Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #782. Treat empty strings in import as zero #784

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Fix for #782. Treat empty strings in import as zero #784

merged 3 commits into from
Feb 15, 2023

Conversation

MatrixCrawler
Copy link
Contributor

This should fix the probem described in #782

mrparkers
mrparkers approved these changes Feb 15, 2023
View reviewed changes
Copy link
Owner

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for submitting this PR!

@mrparkers mrparkers merged commit 9a8c071 into mrparkers:master Feb 15, 2023
@MatrixCrawler
Copy link
Contributor Author

Hey @mrparkers,
when could we have a release for that? This is actually a blocking issue for us :-)

@mrparkers
Copy link
Owner

Hi, sorry about that. I meant to do this week and it slipped my mind. I published v4.2.0 today.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatrixCrawler @mrparkers