Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated keycloak_client.go to support keycloak 22 #903

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

wombat
Copy link
Contributor

@wombat wombat commented Dec 6, 2023

RH SSO changed the ".GA" string at the end of the version to "redhat-00002" with the release of Red Hat Build of Keycloak. I added a more generic approach in case Red Hat changes the number at the end of the version string.

Sample string from the latest release: 22.0.6.redhat-00002

With the provided change we were able to run our Keycloak provisioning successfully without the following error that we see in the 4.3.1:

Error: error initializing keycloak provider
│
│   with provider["registry.terraform.io/mrparkers/keycloak"],
│   on main.tf line 7, in provider "keycloak":
│    7: provider "keycloak" {
│
│ failed to perform initial login to Keycloak: Malformed version: 22.0.6.redhat-00002

RH SSO changed the ".GA" string at the end of the version to "redhat-00002" with the release of Red Hat Build of Keycloak. 
I added a more generic approach in case Red Hat changes the number at the end of the version string.

Sample string from the latest release: 22.0.6.redhat-00002
@simonregn
Copy link

Hi @mrparkers
I have been working with @wombat on this case. Could you please have a look at this? Can this be merged and released?
Thanks :)

@andreas-sundstrom
Copy link

Great work guys! This would help our team out a lot! 👍⭐👍

@johnalmm
Copy link

Same for my team!

@mrparkers
Copy link
Contributor

Sorry for the late review on this. This looks good to me, although I can't verify myself since I don't have access to RedHat SSO. But I'll trust you guys on this one.

Thanks for the PR!

@mrparkers mrparkers merged commit abc191a into keycloak:master Dec 15, 2023
6 checks passed
@simonregn
Copy link

Any plans to release this soon?

@johnalmm
Copy link

Great work!
Yes, getting this to the terraform registry would be golden.

@johnalmm
Copy link

johnalmm commented Jan 3, 2024

@mrparkers Do you have any reason for not doing a new release on the terraform registry with this feature? Could we help out with anything to help make it happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants