-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the Spark-Connect tests with the existing test suite & CI #256
Integrate the Spark-Connect tests with the existing test suite & CI #256
Conversation
… GitHub Actions local setup
…rk-Connect <3.5.2
This was included to perform the GH Actions on the feature/ branches to speed up the development & test when working on the Spark-Connect tests upgrade.
@SemyonSinchenko - let me know your thoughts on the PR. I've updated it to raise exception for anything below Spark-Connect v3.5.2 & updated the test cases too. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @nijanthanvijayakumar !
I will merge it by the end of the day if no new comments.
@jeffbrennan @MrPowers FYI
Thank you for your guidance and support @SemyonSinchenko . Phew😮💨 that was a massive PR, at least for me. |
86c5f18
into
mrpowers-io:planning-1.0-release
Proposed changes
This is related to the #241 issue and the following changes have been made:
Updates to the ci.yml:
Invoke the tests using Spark-Connect & make
Updates to the CONTRIBUTING.md document.
Brings the changes in from the
main
branch describing thepre-commit
installation & setup, and auto-assigning the issues.Refactor the following
*.py
files to work with the Spark-Connect tests and also update the tests accordinglya) dataframe_helpers.py
b) functions.py
c) transformations.py
d) test_functions.py
e) test_transformations.py
[Highlight]: Handling unsupported functions on Spark-Connect less than 3.5.2
a) The functions
array_choice
and thesort_columns
don't work properly on the Spark-Connect v3.5.2 and below. So, raising an exception if the Spark version is < 3.5.2 and ifSPARK_CONNECT_MODE
is enabled.b) Create a wrapper within the
test_transformations.py
, as thesort_columns
function/method is being used widely across 10+ test cases. Using a wrapper would help reduce the duplicate lines of code.Types of changes
What types of changes does your code introduce to Quinn?
Put an
x
in the boxes that applyFurther comments