From 377d5eb758b97928c17e4ef30d505b41fdebc4b1 Mon Sep 17 00:00:00 2001
From: Gabe <41127686+Zidious@users.noreply.github.com>
Date: Tue, 22 Aug 2023 17:59:01 +0100
Subject: [PATCH] ci: ensure tests use newly installed chromedriver and not
 chromedriver from `node_modules` (#794)

---
 .github/workflows/tests.yml | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index dfda6be1db..72a479501a 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -29,10 +29,11 @@ jobs:
           cache: 'npm'
       - run: npm ci
       - run: npm run bootstrap -- --ci
-      - run: npm run build --prefix=packages/puppeteer
       # HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
       - shell: 'script -q -e -c "bash {0}"'
-        run: npx browser-driver-manager install chrome chromedriver --verbose
+        run: npx browser-driver-manager install chromedriver --verbose
+        working-directory: packages/puppeteer
+      - run: npm run build --prefix=packages/puppeteer
       - run: npm run coverage --prefix=packages/puppeteer
       - run: npm run test:esm --prefix=packages/puppeteer
 
@@ -50,9 +51,10 @@ jobs:
           cache: 'npm'
       - run: npm ci
       - run: npm run bootstrap -- --ci
-      # HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
+        # HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
       - shell: 'script -q -e -c "bash {0}"'
-        run: npx browser-driver-manager install chrome chromedriver --verbose
+        run: npx browser-driver-manager install chromedriver --verbose
+        working-directory: packages/cli
       # Re-build packages, ensuring packages/webdriverjs/dist exists.
       - run: npx lerna run prepare
       # lerna link after installing the latest version of chromedriver, as we depend on webdriverJS
@@ -76,7 +78,8 @@ jobs:
       - run: npm run bootstrap -- --ci
       # HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
       - shell: 'script -q -e -c "bash {0}"'
-        run: npx browser-driver-manager install chrome chromedriver --verbose
+        run: npx browser-driver-manager install chromedriver --verbose
+        working-directory: packages/webdriverjs
       - run: npm run build --prefix=packages/webdriverjs
       - run: npm run coverage --prefix=packages/webdriverjs
       - run: npm run test:esm --prefix=packages/webdriverjs
@@ -97,7 +100,8 @@ jobs:
       - run: npm run bootstrap -- --ci
       # HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
       - shell: 'script -q -e -c "bash {0}"'
-        run: npx browser-driver-manager install chrome chromedriver --verbose
+        run: npx browser-driver-manager install chromedriver --verbose
+        working-directory: packages/webdriverio
       - run: npm run build --prefix=packages/webdriverio
       - run: npm run coverage --prefix=packages/webdriverio
       - run: npm run test:esm --prefix=packages/webdriverio