Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Test & document Visibility Control Header with static built libraries #323

Closed
lilustga opened this issue Mar 17, 2021 · 4 comments
Closed
Assignees
Labels
bug Something isn't working Documentation

Comments

@lilustga
Copy link
Contributor

Test a change to the Symbol Visibility Control Header to accommodate building code as a static library. The export macros will be blank in the case of a static library.

The change is discussed in this comment thread:
#322 (comment)

@lilustga lilustga self-assigned this Mar 17, 2021
@traversaro
Copy link
Contributor

To clarify, I usually suggest to support the static usecase for standalone libraries so that they can be easily packaged inside vcpkg (https://github.com/Microsoft/vcpkg) for all the official supported triplets.

@ooeygui
Copy link
Member

ooeygui commented Aug 11, 2021

@ooeygui ooeygui closed this as completed Aug 11, 2021
@ooeygui ooeygui reopened this Aug 11, 2021
@ooeygui ooeygui added bug Something isn't working Documentation labels Aug 11, 2021
@ooeygui
Copy link
Member

ooeygui commented Aug 11, 2021

We need to move our symbol visibility doc to ROS.org. And add the CMake doc

@IoTDan
Copy link

IoTDan commented Oct 13, 2022

fixed - documented and published

@IoTDan IoTDan closed this as completed Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Documentation
Projects
None yet
Development

No branches or pull requests

4 participants