-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify node-gyp
as a dependency.
#1378
Comments
My projects target npm because that's what's always been bundled with node. npm bundles node-gyp. AFAIK there is no way to ensure that only one copy of it is installed if I were to add it as an explicit dependency in one way or another. |
Besides, node-gyp is not required for this project anyway, it's optional. |
I'm guessing the concern is that it should be marked as an optional peer dependency, per the last sentence in the error:
It should have a As is, the failure is fatal, because it is neither marked as provided by the environment nor optional. It seems like a trivial fix. I can open a PR. |
I'm getting this error in my Cloudflare Worker when using Yarn 4:
While I can go about manually installing it at the root, I figured it was worth asking to fix it at the source if possible.
The text was updated successfully, but these errors were encountered: