Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete on inputs #127

Closed
paullryan opened this issue Oct 3, 2016 · 3 comments
Closed

Autocomplete on inputs #127

paullryan opened this issue Oct 3, 2016 · 3 comments
Assignees
@paullryan
Labels
Enhancement PR Welcome

Comments

@paullryan
Copy link
Contributor

We should be passing the autocomplete attribute through to the input like we do with the placeholder. See https://html.spec.whatwg.org/multipage/forms.html#autofill for information on autocomplete/autofill.
@mseemann
Copy link
Owner

mseemann commented Oct 3, 2016

right...

@paullryan
Copy link
Contributor Author

I'll have a PR ready for this in the next few hours.

Side Question: If I do this against master only are you pulling between master and 2.0?

@mseemann
Copy link
Owner

mseemann commented Oct 3, 2016

great!
master will be 2.0. if you need it asap please do it against branch angular2-mdl-1.x

@paullryan paullryan mentioned this issue Oct 3, 2016
Merged
@mseemann mseemann added this to the version 2.0.0 milestone Oct 4, 2016
@mseemann mseemann closed this as completed Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paullryan paullryan

Labels
Enhancement PR Welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mseemann @paullryan