From de88aaf25cc216071d9008fe42677d34918c11c5 Mon Sep 17 00:00:00 2001 From: Rick Date: Sat, 9 Oct 2021 11:58:10 -0500 Subject: [PATCH 1/2] Address Edgecase where custom activity fields are written as Task/Event fields in xml --- src/commands/shane/object/perms/align.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/commands/shane/object/perms/align.ts b/src/commands/shane/object/perms/align.ts index 08d5732..11fcafd 100644 --- a/src/commands/shane/object/perms/align.ts +++ b/src/commands/shane/object/perms/align.ts @@ -95,6 +95,8 @@ export default class PermAlign extends SfdxCommand { const fieldName = `${item.field.split('.')[1]}.field-meta.xml`; if (objects.includes(objectName) && fs.readdirSync(`${objDir}/${objectName}/fields`).includes(fieldName)) { return true; + } else if ((objectName == 'Task' || objectName == 'Event') && fs.readdirSync(`${objDir}/Activity/fields`).includes(fieldName)) { + return true; } this.ux.log(`${chalk.cyan(targetFilename)}: removing field perm for ${item.field}`); return false; From 2011ca0098dcffd81df387e2f0bc997add041bda Mon Sep 17 00:00:00 2001 From: Rick Date: Thu, 6 Jan 2022 14:25:24 -0600 Subject: [PATCH 2/2] Special handling of Global layouts because there is no Global object --- src/commands/shane/object/perms/align.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/commands/shane/object/perms/align.ts b/src/commands/shane/object/perms/align.ts index 11fcafd..df34709 100644 --- a/src/commands/shane/object/perms/align.ts +++ b/src/commands/shane/object/perms/align.ts @@ -108,6 +108,8 @@ export default class PermAlign extends SfdxCommand { const objectName = item.layout.split('-')[0]; if (objects.includes(objectName) && layouts.includes(`${item.layout}.layout-meta.xml`)) { return true; + } else if (objectName == 'Global' && layouts.includes(`${item.layout}.layout-meta.xml`)) { + return true; } this.ux.log(`${chalk.cyan(targetFilename)}: removing layout assignment for ${item.layout}`); return false;