Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not activate/load extension until required #327

Closed
dominiksalvet opened this issue Nov 6, 2022 · 3 comments · Fixed by #330
Closed

Do not activate/load extension until required #327

dominiksalvet opened this issue Nov 6, 2022 · 3 comments · Fixed by #330
Labels

Comments

@dominiksalvet
Copy link

Describe the bug
The extension is activated on VSCode startup:

image

I personally use multi-root workspaces and I have projects written in various languages, so the extension is often activated unnecessarily and adds extra start time.

Environment (please complete the following information):

  • OS: Ubuntu 22.04.1 LTS
  • VS Code version 1.73.0
  • Extension version 1.5.4

Steps to reproduce
Steps to reproduce the behavior:

  1. Install the extension
  2. Close and open VSCode
  3. Open extensions
  4. See it activated and that took some time (e.g., 349 ms)

Expected behavior
It may be activated on some events. E.g. see the screenshot of Pylance config:

Screenshot from 2022-11-06 22-01-52

Actual behavior
It is activated on every VSCode startup.

@mshr-h
Copy link
Owner

mshr-h commented Nov 10, 2022

Because this extension is currently not adopted to Multi Root Workspace API.

@mshr-h
Copy link
Owner

mshr-h commented Nov 10, 2022

Addressed on v1.5.5.

@mshr-h mshr-h reopened this Nov 10, 2022
@dominiksalvet
Copy link
Author

Thank you! It works great. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants