Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of t_depth vs. t_alt_count + t_ref_count #44

Open
andurill opened this issue Sep 23, 2020 · 0 comments
Open

Use of t_depth vs. t_alt_count + t_ref_count #44

andurill opened this issue Sep 23, 2020 · 0 comments

Comments

@andurill
Copy link

Hi,

There is a minor error here: https://github.com/mskcc/facets-suite/blob/master/R/ccf-annotate-maf.R#L29. The check is for the presence of t_alt_count and t_ref_count columns, but the error message is "Columns t_alt_count and t_depth required."

Also, in the same module, I think it will be useful to add an optional argument to enable using t_depth values present in the maf file directly for calculating t_var_freq, instead of calculating t_depth as t_alt_count + t_ref_count. This is because:
1.) In multi-allelic sites, calculating t_depth as t_alt_count + t_ref_count might be incorrect.
2.) Although rare, in some input maf files, only the t_depth and t_alt_count columns are populated. This causes NA to be coerced for all columns related to ccf.

I made the update above for my usage. If this of any interest to you, I'm happy to do a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant