Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_knot claims to handle floating point errors, but seems to cause them #252

Open
amaramth opened this issue Aug 28, 2024 · 0 comments
Open

Comments

@amaramth
Copy link

if i run the getting started hello world, but replace spline.equidistant_knot_seq(15) with spline.equidistant_knot_seq(7000), it makes lots of NaN, but if i remove tinyspline.c#L1216-L1222 the results appear correct

 * It is recommended that ::TS_KNOT_EPSILON is aligned to the span of
 * ::TS_DOMAIN_DEFAULT_MIN and ::TS_DOMAIN_DEFAULT_MAX. That is, adjacent
 * floating point values in the domain [::TS_DOMAIN_DEFAULT_MIN,
 * ::TS_DOMAIN_DEFAULT_MAX] should not be equal according to
 * ::TS_KNOT_EPSILON.

this issue may be related to the default TS_KNOT_EPSILON not having this property

i'd like to know what the purpose of lines 1216-1222 is, in case removing them bites later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant