From 686d3d668f7b76cbf26f75c990fded5e4fd298da Mon Sep 17 00:00:00 2001 From: Artem Zakharchenko Date: Wed, 8 May 2024 15:49:37 +0200 Subject: [PATCH] fix(Disposable): make the ".dispose()" method synchronous (#2144) --- src/core/utils/internal/Disposable.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/core/utils/internal/Disposable.ts b/src/core/utils/internal/Disposable.ts index ca61652ab..42a680880 100644 --- a/src/core/utils/internal/Disposable.ts +++ b/src/core/utils/internal/Disposable.ts @@ -1,9 +1,12 @@ -export type DisposableSubscription = () => Promise | void +export type DisposableSubscription = () => void export class Disposable { protected subscriptions: Array = [] - public async dispose() { - await Promise.all(this.subscriptions.map((subscription) => subscription())) + public dispose() { + let subscription: DisposableSubscription | undefined + while ((subscription = this.subscriptions.shift())) { + subscription() + } } }