Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @mswjs/interceptors ^0.18.0 #1484

Closed
1 task
cdimitroulas opened this issue Nov 29, 2022 · 4 comments
Closed
1 task

Update to @mswjs/interceptors ^0.18.0 #1484

cdimitroulas opened this issue Nov 29, 2022 · 4 comments
Labels

Comments

@cdimitroulas
Copy link

Scope

Adds a new behavior

Compatibility

  • This is a breaking change

Feature description

@mswjs/interceptors v0.18.0 has support for upload events which would be great to incorporate in the higher-level msw library.

I'm happy to take a stab at this, but I'm completely unfamiliar with the codebase so it has proven challenging to understand how to adapt msw to the breaking changes from @mswjs/interceptors.

In particular, I see that IsomorphicRequest was removed - what's the correct way to handle this change? I would love to help out by creating a PR for this but I could use some guidance here :)

@cdimitroulas
Copy link
Author

Ah I see this is already covered by this WIP PR: #1436

@kettanaito
Copy link
Member

Hey, @cdimitroulas. Yes, version 0.18.0 introduces Fetch API primitives to our Node.js request interception library. We've migrated to it as a part of a larger change, which is #1436.

If you have a minute, I'd be thankful if you give that new change a try. You can find more info in this discussion: #1464. Thanks!

@cdimitroulas
Copy link
Author

@kettanaito thanks for explaining. I did try to give the new change a whirl yesterday but got stuck due to the issue which has already been raised on #1464 about Unexpected token 'export'.
I'm trying to find time to push forwards on mswjs/interceptors#283 in order to get that problem fixed

@kettanaito
Copy link
Member

Thank you so much for looking into this! I will support you with code reviews.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants