Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static linking with libssh and libsrt #11513

Closed
msink opened this issue Apr 18, 2022 · 5 comments · Fixed by #11531
Closed

Static linking with libssh and libsrt #11513

msink opened this issue Apr 18, 2022 · 5 comments · Fixed by #11531
Labels
reported-upstream Issues reported or fixed in upstream repository

Comments

@msink
Copy link

msink commented Apr 18, 2022 •
edited
Loading

If both libssh.a and libsrt.a have to be linked in application - linker error:

...\lib\libssh.a(libcrypto.c.obj):(.text+0x1000): multiple definition of `md5_init'; ...\lib\libsrt.a(md5.cpp.obj):md5.cpp:(.text+0x850): first defined here

To repoduce: see #8824 (comment)
replace -l:libssh.dll.a to -lssh
@msink msink mentioned this issue Apr 18, 2022
Open
@Biswa96
Copy link
Member

Biswa96 commented Apr 18, 2022

Those are two totally different object files in different libraries i.e. libcrypto.c.obj and md5.cpp.obj. Can we do anything from packaging side?

@msink
Copy link
Author

msink commented Apr 18, 2022 •
edited
Loading

Somehow make md5_init function prefixed in libssh or libsrt (or both)?

@Biswa96
Copy link
Member

Biswa96 commented Apr 18, 2022 •
edited
Loading

That should be asked in upstream. Let me discuss that in those repositories.

@Biswa96 Biswa96 changed the title Static linking with libssh and libstr Static linking with libssh and libsrt Apr 18, 2022
@Biswa96
Copy link
Member

Biswa96 commented Apr 18, 2022

How can we make sure that no other project is using that function from libssh or libsrt?

@Biswa96
Copy link
Member

Biswa96 commented Apr 19, 2022

I have sent a pull request in srt project Haivision/srt#2301.

@Biswa96 Biswa96 added the reported-upstream Issues reported or fixed in upstream repository label Apr 19, 2022
@Biswa96 Biswa96 mentioned this issue Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reported-upstream Issues reported or fixed in upstream repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

srt: Fix name conflict with md5 functions
2 participants
@msink @Biswa96