Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notowned with an empty codeowners file #126

Closed
electriquo opened this issue Feb 27, 2022 · 1 comment · Fixed by #130
Closed

notowned with an empty codeowners file #126

electriquo opened this issue Feb 27, 2022 · 1 comment · Fixed by #130
Assignees
Labels
bug Something isn't working

Comments

@electriquo
Copy link

Description

Using version 0.7.1 with an empty CODEOWNERS file and setting experimental_checks: notowned displays an error and it does not fail the execution (see Actual result for the error message).

Expected result

If there is an error, the validator should fail with non zero exit code

Actual result

time="2022-02-27T09:21:01Z" level=error msg="while executing checker [Experimental] Not Owned File Checker: 1 error occurred:\n\t* fatal: No pathspec was given. Which files should I remove?\n: command \"xargs\": exit status 123\n\n" service="check:runner"

Steps to reproduce

Use the same setup as #121 with an empty CODEOWNERS file.

Troubleshooting

  • Used the same setup with a CODEOWNERS with a single line * @org/team and the error did not appear
@mszostok
Copy link
Owner

It was a known issue:

// TODO(mszostok): add err handling (logging it internally is not enough)

But now it's fixed by #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants