Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage to internal pkg #14

Closed
3 tasks done
mszostok opened this issue Nov 13, 2019 · 3 comments
Closed
3 tasks done

Add test coverage to internal pkg #14

mszostok opened this issue Nov 13, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone
v0.5.0

Comments

@mszostok
Copy link
Owner

mszostok commented Nov 13, 2019 •
edited
Loading

Description

Currently, only the pkg package has full test coverage. The internal pkg also should be full-tested. The coverage reports should be generated and reported on some external services that we do not have to manage.

Choose one of the following services:

Acceptance Criteria

  • test coverage for internal pkg to never regress, and ensure that the contract will not be broken in the future releases
  • publish report coverage on external platform
  • integration tests against the real organization
@mszostok mszostok added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 13, 2019
@mszostok mszostok added this to the Upcoming - Minor milestone Nov 13, 2019
@mszostok mszostok mentioned this issue Nov 13, 2019
Merged
@mszostok mszostok mentioned this issue May 4, 2020
Merged
@mszostok
Copy link
Owner Author

mszostok commented May 5, 2020

The integration tests were added in this PR: #30

@mszostok mszostok modified the milestones: Upcoming - Minor, v0.5.0 May 5, 2020
@mszostok mszostok added enhancement New feature or request and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 5, 2020
This was referenced May 10, 2020
Closed
Merged
@mszostok mszostok mentioned this issue Oct 17, 2020
Merged
@mszostok
Copy link
Owner Author

The unit-test coverage was increased here: #43

@mszostok mszostok mentioned this issue Oct 23, 2020
Merged
@mszostok
Copy link
Owner Author

The unit-tests were added for all places where it makes sense. Rest is covered by integration tests.

There is a follow-up issue to show the test-coverage from integration tests (#49)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
1 participant
@mszostok