-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native support for pre-commit hook #140
Comments
Hi @peterdemin and @jeremycohen! You both posted that the pre-commit support would be nice to see in codeowners-validator. Do you already have snippets on how you use it with pre-commit? I see, one problem that the CLI supports for now only env variables, where pre-commit allows only flags. For example:
Additionally, you want to use the docker_image, go or system option? The last option, AFAIK, the bin needs to be preinstalled. |
I don't like our setup, because we don't have control over which version to use. I still put it here so others could avoid our mistakes: We use
|
Sorry I didn't get back sooner. Here's roughly how we currently use this script to look for unowned files in a specific subdirectory:
We don't have a precommit hook yet for this, but I would guess it would look like @peterdemin's setup if we were to do so (lower-pri item for us, not typically a common error to hit for devs). |
Hi @mszostok, any updates on this one? |
Since this is apparently dead, what about #199? |
@dannysauer @mszostok I'd be happy to fix any issues I had when I wrote the PR last year. :) |
Description
The native support for
pre-commit
hook was requested by external users.To integrate with https://pre-commit.com/ the
.pre-commit-hooks.yaml
file needs to be added to the root for repository.Example:
To support the input parameters, the
codeowners-validator
CLI should accept flags or config file.Reasons
Support https://pre-commit.com/ out of the box to simplify external user workflow.
The text was updated successfully, but these errors were encountered: