You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all thank you for this tool, it helped me fixed CODEOWNERS for https://github.com/godotengine/godot
Turns out that review-requests don't work for teams without Write permission for some reason (as if a review from someone not able to press "Merge" is not valid), but your tool caught it + more issues :)
Version
0.6.0, installed in ./bin with curl instructions.
# In this example, @octocat owns any file in an apps directory
# anywhere in your repository.
apps/ @octocat
This will successfully match apps/ directories in any directory of the repository, even if there's no apps/ directory in the root.
But codeowners-validator issues a warning about this case.
Expected result
No warning if any nested directory matches the pattern.
Actual result
==> Executing File Exist Checker (45.227677ms)
[err] line 11: "SCsub" does not match any files in repository
[err] line 23: "doc_classes/*" does not match any files in repository
Yet:
$ find -type f -name SCsub | wc -l
124
$ find -type d -name doc_classes | wc -l
19
name: codeowners-validatoron:
schedule:
# Runs at 08:00 UTC every day
- cron: '0 8 * * *'workflow_dispatch:
jobs:
sanity:
runs-on: ubuntu-lateststeps:
# Checks-out your repository, which is validated in the next step
- uses: actions/checkout@v2
- name: GitHub CODEOWNERS Validatoruses: mszostok/codeowners-validator@v0.6.0with:
checks: "owners,duppatterns,syntax"# `files` check not specified experimental_checks: "notowned"# GitHub access token is required only if the `owners` check is enabledgithub_access_token: "${{ secrets.OWNERS_VALIDATOR_GITHUB_SECRET }}"
In the meantime I will check implementation and I will ping you when new version with fix will be available :)
First of all thank you for this tool, it helped me fixed
CODEOWNERS
for https://github.com/godotengine/godotTurns out that review-requests don't work for teams without
Write
permission for some reason (as if a review from someone not able to press "Merge" is not valid), but your tool caught it + more issues :)Version
0.6.0, installed in
./bin
with curl instructions.Description
There seems to be a false positive report from the File Exist Checker when using relative paths which are then checked in all directories by
CODEOWNERS
.What I mean is what is described here: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
This will successfully match
apps/
directories in any directory of the repository, even if there's noapps/
directory in the root.But
codeowners-validator
issues a warning about this case.Expected result
No warning if any nested directory matches the pattern.
Actual result
Yet:
(This is on https://github.com/godotengine/godot/)
Steps to reproduce
env REPOSITORY_PATH="." OWNER_CHECKER_REPOSITORY="godotengine/godot" ./bin/codeowners-validator
Troubleshooting
n/a
The text was updated successfully, but these errors were encountered: