Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocrafter does not invoke on_craft callback, resulting in invalid results #67

Open
fluxionary opened this issue May 25, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@fluxionary
Copy link
Member

e.g. the recipe for crafting a written book + an empty book to create a copy of the empty book results in empty written books. also, crafting moretrees coconut milk (coconut + axe + drinking cup) eats the axe for similar reasons.

see this approach i took for the unified_inventory_plus "craft all" button for an outline of how to do this correctly, though it will need to be adapted to pipeworks (e.g. the autocrafter doesn't have a real "crafting grid" inventory).

@S-S-X
Copy link
Member

S-S-X commented May 25, 2023

See also comments on #63
There's some other things that should be considered before/while doing this.

@S-S-X S-S-X added the enhancement New feature or request label May 25, 2023
@OgelGames OgelGames mentioned this issue May 16, 2024
4 tasks
@OgelGames OgelGames self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants