-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mining Drill Breaks Unbreakable Items #261
Comments
Relevant code: technic/technic/tools/mining_drill.lua Lines 49 to 65 in ec3a52c
Looks like there is basically just a hardcoded blacklist 😖 Parts of the quarry-code could be used to replace that, or even shared globally: technic/technic/machines/HV/quarry.lua Lines 172 to 184 in ec3a52c
EDIT: the |
Not sure if this could be a feature-bug or not, probably better to fix it though. (I wonder if it might be good to add fixes for other feature-bugs with a setting to allow them)
Yep, the drills haven't gotten a rewrite yet :)
That was just a minor optimization for the quarry. (no clue if it actually makes any significant difference) |
Can we just use the code from the quarry for the drill? It looks like it would work better, since it's less hardcoded. |
Sure, that's the plan, no one is working on that currently so if you want to try that, go ahead 👍 |
Not on that exact issue but I would still request minimal changes to avoid big conflicts with #233 There's just one PR I've added few days ago and promised to add another optional PR soon after. not done that yet but I do have code available that should be fine. |
The mining drills provided by this mod are able to break normally unbreakable blocks, such as default:cloud.
Should be simple enough to fix
The text was updated successfully, but these errors were encountered: