Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic Screwdriver doesn't rotate sign text when using signs_lib #330

Open
dontfwiththestream opened this issue Oct 21, 2023 · 1 comment
Labels
Bug Something isn't working

Comments

@dontfwiththestream
Copy link

Expected behavior

Text on sign rotates when you use sonic screwdriver on sign

Actual behavior

Sign rotates, leaving text position unchanged

Steps to reproduce:

Start server with signs_lib and technic_plus
write text on sign
rotate with sonic screwdriver

@OgelGames
Copy link
Contributor

Yeah, this is a side effect of the sonic screwdriver's intentionally bad design. The sonic screwdriver doesn't call the on_rotate callback, for the same reason it doesn't call can_dig. See also #267.

-- contrary to the default screwdriver, do not check for can_dig, to allow rotating machines with CLU's in them
-- this is consistent with the previous sonic screwdriver

It's better just to use the omnidriver ;)

@OgelGames OgelGames added the Bug Something isn't working label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants