Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for craftguide mod recipe registration (#584) #174

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

S-S-X
Copy link
Member

@S-S-X S-S-X commented Apr 14, 2021

Closes #168

@S-S-X S-S-X added the Enhancement New feature or request label Apr 14, 2021
@github-actions
Copy link

Click for detailed source code test coverage report

Test coverage report for technic 9.66% in 10/102 files:

File                                      Hits Missed Coverage
--------------------------------------------------------------
config.lua                                45   4      91.84%
crafts.lua                                0    86     0.00%
effects.lua                               0    3      0.00%
helpers.lua                               0    116    0.00%
init.lua                                  0    30     0.00%
integration_test.lua                      0    24     0.00%
items.lua                                 0    51     0.00%
legacy.lua                                0    7      0.00%
machines/HV/battery_box.lua               0    6      0.00%
machines/HV/cables.lua                    9    19     32.14%
machines/HV/compressor.lua                0    6      0.00%
machines/HV/electric_furnace.lua          0    6      0.00%
machines/HV/forcefield.lua                0    213    0.00%
machines/HV/generator.lua                 9    0      100.00%
machines/HV/grinder.lua                   0    6      0.00%
machines/HV/init.lua                      0    12     0.00%
machines/HV/nuclear_reactor.lua           0    266    0.00%
machines/HV/quarry.lua                    0    252    0.00%
machines/HV/solar_array.lua               0    6      0.00%
machines/LV/alloy_furnace.lua             0    6      0.00%
machines/LV/battery_box.lua               0    6      0.00%
machines/LV/cables.lua                    10   19     34.48%
machines/LV/compressor.lua                0    10     0.00%
machines/LV/electric_furnace.lua          0    6      0.00%
machines/LV/extractor.lua                 0    13     0.00%
machines/LV/generator.lua                 0    7      0.00%
machines/LV/geothermal.lua                0    56     0.00%
machines/LV/grinder.lua                   0    7      0.00%
machines/LV/init.lua                      0    16     0.00%
machines/LV/lamp.lua                      0    107    0.00%
machines/LV/music_player.lua              0    81     0.00%
machines/LV/solar_array.lua               0    6      0.00%
machines/LV/solar_panel.lua               0    27     0.00%
machines/LV/water_mill.lua                0    47     0.00%
machines/MV/alloy_furnace.lua             0    6      0.00%
machines/MV/battery_box.lua               0    6      0.00%
machines/MV/cables.lua                    10   19     34.48%
machines/MV/centrifuge.lua                0    6      0.00%
machines/MV/compressor.lua                0    6      0.00%
machines/MV/electric_furnace.lua          0    6      0.00%
machines/MV/extractor.lua                 0    6      0.00%
machines/MV/freezer.lua                   0    6      0.00%
machines/MV/generator.lua                 0    7      0.00%
machines/MV/grinder.lua                   0    6      0.00%
machines/MV/hydro_turbine.lua             0    44     0.00%
machines/MV/init.lua                      0    17     0.00%
machines/MV/lighting.lua                  0    170    0.00%
machines/MV/power_radiator.lua            0    96     0.00%
machines/MV/solar_array.lua               0    7      0.00%
machines/MV/tool_workshop.lua             0    73     0.00%
machines/MV/wind_mill.lua                 0    45     0.00%
machines/compat/digtron.lua               0    13     0.00%
machines/init.lua                         0    85     0.00%
machines/network.lua                      193  163    54.21%
machines/other/anchor.lua                 0    79     0.00%
machines/other/coal_alloy_furnace.lua     0    94     0.00%
machines/other/coal_furnace.lua           0    3      0.00%
machines/other/constructor.lua            0    103    0.00%
machines/other/frames.lua                 0    551    0.00%
machines/other/init.lua                   0    8      0.00%
machines/other/injector.lua               0    85     0.00%
machines/power_monitor.lua                0    57     0.00%
machines/register/alloy_furnace.lua       0    30     0.00%
machines/register/alloy_recipes.lua       0    27     0.00%
machines/register/battery_box.lua         0    238    0.00%
machines/register/cables.lua              168  49     77.42%
machines/register/centrifuge.lua          0    6      0.00%
machines/register/centrifuge_recipes.lua  0    25     0.00%
machines/register/common.lua              0    114    0.00%
machines/register/compressor.lua          0    6      0.00%
machines/register/compressor_recipes.lua  0    33     0.00%
machines/register/electric_furnace.lua    0    6      0.00%
machines/register/extractor.lua           0    6      0.00%
machines/register/extractor_recipes.lua   0    71     0.00%
machines/register/freezer.lua             0    6      0.00%
machines/register/freezer_recipes.lua     0    12     0.00%
machines/register/generator.lua           91   114    44.39%
machines/register/grinder.lua             0    6      0.00%
machines/register/grinder_recipes.lua     0    100    0.00%
machines/register/grindings.lua           0    39     0.00%
machines/register/init.lua                0    22     0.00%
machines/register/machine_base.lua        0    166    0.00%
machines/register/recipes.lua             0    78     0.00%
machines/register/solar_array.lua         0    30     0.00%
machines/supply_converter.lua             75   66     53.19%
machines/switching_station.lua            0    79     0.00%
machines/switching_station_globalstep.lua 0    58     0.00%
max_lag.lua                               0    10     0.00%
radiation.lua                             0    138    0.00%
register.lua                              20   20     50.00%
tools/cans.lua                            0    71     0.00%
tools/chainsaw.lua                        0    115    0.00%
tools/flashlight.lua                      0    68     0.00%
tools/init.lua                            0    14     0.00%
tools/mining_drill.lua                    0    268    0.00%
tools/mining_lasers.lua                   0    65     0.00%
tools/multimeter.lua                      0    208    0.00%
tools/prospector.lua                      0    101    0.00%
tools/sonic_screwdriver.lua               0    51     0.00%
tools/tree_tap.lua                        0    38     0.00%
tools/vacuum.lua                          0    32     0.00%
util/throttle.lua                         0    11     0.00%

Raw test runner output for geeks:

●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●◌●●●●●
57 successes / 0 failures / 0 errors / 1 pending : 0.155997 seconds

Pending → spec/supply_converter_spec.lua @ 99
Supply converter building overloads network
spec/supply_converter_spec.lua:99: overload does not work with supply converter

@S-S-X
Copy link
Member Author

S-S-X commented Apr 14, 2021

Merged to official technic, cherry picked from there. I've not tested this at all but also don't see any problems, no conflicts with actual code.

@BuckarooBanzay
Copy link
Member

nice 👍 looks good, haven't tested it though

@S-S-X S-S-X merged commit bc9a775 into master Apr 15, 2021
@OgelGames OgelGames deleted the craftguide-support branch May 5, 2021 09:48
S-S-X added a commit that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

craftguide support
3 participants