Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to stop/restart watch #137

Closed
webjoel opened this issue Aug 31, 2018 · 6 comments · Fixed by #163
Closed

Add button to stop/restart watch #137

webjoel opened this issue Aug 31, 2018 · 6 comments · Fixed by #163

Comments

@webjoel
Copy link

webjoel commented Aug 31, 2018

The lib node-tail tail enables to start/stop watch:

tail.watch();

tail.unwatch();

It's very good for many logs in little time when necessary analyse the log, so watch stop and after, start watch again.

It would be interesting to add this feature in this project as well.

I have an application that generates many logs.

@mthenw
Copy link
Owner

mthenw commented Aug 31, 2018

Hey @webjoel

are you referring to https://www.npmjs.com/package/node-tail?

@webjoel
Copy link
Author

webjoel commented Aug 31, 2018

@mthenw Not, really is: https://www.npmjs.com/package/tail

Suggestion:

1 - Use this lib I quoted;
2 - Create the similar feature in this project;

@mthenw
Copy link
Owner

mthenw commented Sep 4, 2018

I've been thinking about switching to this library (which also means supporting Windows OS) but there is no way to set an initial number of lines. Not sure how it will perform. I need to test it.

@webjoel
Copy link
Author

webjoel commented Sep 4, 2018

I understand, meanwhile, in the current implementation, is it possible to add this stop and continue feature?

@mthenw
Copy link
Owner

mthenw commented Sep 5, 2018

Technically it's possible, but I'm probably not able to spend time on that. Are you interested in contributing?

@webjoel
Copy link
Author

webjoel commented Sep 5, 2018

Okay, I'll try to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants