Not shutting down via signals if usage reporting is disabled

[apeteri]

Hi Maciej,

I am using release 4.5.3 with a systemd service script, and I have noticed that the service waits for the whole ~90 second grace period when stopping, before it gets killed forcefully. Systemd attempts to stop a service by sending SIGTERM to its process group by default.

It seems that the callback for usage stats reporting in stats.js is not invoked if no tracker instance exists:

frontail/lib/stats.js

Lines 57 to 63 in 205cdbf

	Stats.prototype.timeEnd = function timeEnd(category, action, cb) {
	if (!this.tracker) {
	return;
	}
	this.tracker.timing(category, action, Date.now() - this.timer[category][action]).send(cb);
	};

Due to this, signals have no effect at the end of index.js:

frontail/index.js

Lines 159 to 165 in 205cdbf

	const cleanExit = () => {
	stats.timeEnd('runtime', 'runtime', () => {
	process.exit();
	});
	};
	process.on('SIGINT', cleanExit);
	process.on('SIGTERM', cleanExit);

Regards,
András

[apeteri]

Possible duplicate of #158.

[mthenw]

Thanks for reporting. I will take a look.

[mthenw]

I released new version v.4.5.4. Please confirm that it works now.

[apeteri]

Looks good, now the process stops immediately. Thanks! 😃