Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace native tail with fs-tail-stream #175

Closed
wants to merge 2 commits into from

Conversation

mojoaxel
Copy link
Contributor

@mojoaxel mojoaxel commented Aug 3, 2019

fixes #111 (windows support)

@mojoaxel mojoaxel mentioned this pull request Aug 3, 2019
@mthenw
Copy link
Owner

mthenw commented Aug 6, 2019

Wow, thanks for that PR. I will review it later today!

lib/tail.js Outdated Show resolved Hide resolved
@mthenw
Copy link
Owner

mthenw commented Aug 6, 2019

Also, do you know if fs-tail-stream supports log rotation?

@mojoaxel
Copy link
Contributor Author

mojoaxel commented Aug 6, 2019

Also, do you know if fs-tail-stream supports log rotation?

I don't think so 😢
This probably kills this PR

@mojoaxel
Copy link
Contributor Author

mojoaxel commented Aug 6, 2019

Log-rotation is a problem! I tested it and the results are not pretty.
I don't think adding windows support in favor of log-rotation makes sense. 😞

Maybe I find another way to fix #111.

@mojoaxel mojoaxel closed this Aug 6, 2019
@mojoaxel mojoaxel mentioned this pull request Jan 31, 2020
@mojoaxel
Copy link
Contributor Author

@mthenw Could you please reopen this PR!

I've updated my branch to make the windows support additional to the existing tail support!
This way the existing functionality does not change and the windows support is just a fallback for systems without the tail command. Windows support is still missing support for log rotation.

I think a lot of people would like to use frontail on windows even without log-rotation support!

@mthenw
Copy link
Owner

mthenw commented Feb 2, 2020

I'm not able to open this PR. Can you open a new one?

@mojoaxel mojoaxel mentioned this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows support
2 participants