Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Windows install in GitHub actions #94

Closed
j-adamczyk opened this issue Jan 12, 2025 · 4 comments
Closed

Error on Windows install in GitHub actions #94

j-adamczyk opened this issue Jan 12, 2025 · 4 comments

Comments

@j-adamczyk
Copy link

j-adamczyk commented Jan 12, 2025

We are migrating from https://github.com/tiangolo/poetry-version-plugin to https://github.com/mtkennerly/poetry-dynamic-versioning for scikit-fingerprints (https://github.com/scikit-fingerprints/scikit-fingerprints). This Poetry plugin relies on dunamai, but fails on GitHub Actions during Windows installation, with error:

Run poetry sync --with test
Creating virtualenv skfp in D:\a\scikit-fingerprints\scikit-fingerprints\.venv
Ensuring that the Poetry plugins required by the project are available...
The following Poetry plugins are required by the project but are not installed in Poetry's environment:
  - poetry-dynamic-versioning[plugin] (>=1.0.0,<2.0.0)
Installing Poetry plugins only for the current project...
Updating dependencies
Resolving dependencies...

Package operations: 4 installs, 0 updates, 0 removals

  - Installing markupsafe (3.0.2)
  - Installing dunamai (1.23.0)
  - Installing jinja2 (3.1.5)

  ValueError

  path is on mount 'C:', start on mount 'D:'

  at <frozen ntpath>:766 in relpath

Cannot install dunamai.


Failed to install required Poetry plugins
Error: Process completed with exit code 1.

Full log: https://github.com/scikit-fingerprints/scikit-fingerprints/actions/runs/12736416081/job/35496372898?pr=346.
Workflow definition: https://github.com/scikit-fingerprints/scikit-fingerprints/blob/eaa1499a12db49e128808f920df61d8004ef396e/.github/workflows/python-publish.yml.
pyproject.toml file: https://github.com/scikit-fingerprints/scikit-fingerprints/blob/eaa1499a12db49e128808f920df61d8004ef396e/pyproject.toml.

@mtkennerly
Copy link
Owner

mtkennerly commented Jan 13, 2025

Hi! This sounds like an issue in Poetry itself. Could you please add -vvv to the Poetry command and post the full output here?

It looks like Poetry may need a fix related to this:

https://docs.python.org/3/library/os.path.html#os.path.relpath

On Windows, ValueError is raised when path and start are on different drives.

Once you have the -vvv output, I would recommend opening a ticket in the Poetry repo with the details.

@j-adamczyk
Copy link
Author

@mtkennerly sure, here is the debug log: https://github.com/scikit-fingerprints/scikit-fingerprints/actions/runs/12743574960/job/35513793864?pr=346. As far as I can tell, the problem is that Poetry venv gets created on D partition, but cache is on C one.

@mtkennerly
Copy link
Owner

Looks like someone else recently opened a ticket for the same issue: python-poetry/poetry#10028

@j-adamczyk
Copy link
Author

Thanks for fast responses and help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants