Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Pokemon.BaseExperience nullable. #37

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

Towodile
Copy link
Contributor

A JsonSerializationException no longer gets thrown, fixing issue #36.

A JsonSerializationException will no longer be thrown for Pokemon with "base_experience: null", for the int can be converted to null now.
Copy link
Owner

@jtwotimes jtwotimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtwotimes
Copy link
Owner

I'll have a new release created with this fix in it later today.

@jtwotimes jtwotimes merged commit 97458e9 into jtwotimes:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants