Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install pylyzer to install erg as well #50

Closed
h5rdly opened this issue Sep 8, 2023 · 2 comments
Closed

pip install pylyzer to install erg as well #50

h5rdly opened this issue Sep 8, 2023 · 2 comments

Comments

@h5rdly
Copy link

h5rdly commented Sep 8, 2023

Hi,

First of all, cheers for this awesome package.

Would it be possible to add the Erg installation to setup.py, or by some other method, so that erg is installed when one runs
pip install pylyzer?

(ie the same way pandas installs numpy etc. for you when you run pip install pandas)

Thanks,
Eli

@mtshiba
Copy link
Owner

mtshiba commented Sep 9, 2023

The reason erg is in pylyzer's dependencies is not because pylyzer calls the Erg compiler. What is really needed is a set of type definition files for the Erg standard library. pylyzer itself can be installed with pip, but the installation of this library requires cargo or ergup.

So we want to run ergup during pip installation. This is what I am currently trying to do, however, I don't know how to make the pre-install script run while installing the wheel package.

@mtshiba
Copy link
Owner

mtshiba commented Oct 4, 2023

Now you can now install pylyzer using pip without any additional action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants