-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(llama.cpp): enable ROCm/HIPBLAS support #1100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to dance around the fact llama-stable doesn't support this (I think?) by using a plain CPU build type there. I guess clblas would be ideal, but it requires additional parameters. Signed-off-by: 65a <65a@63bit.net>
Signed-off-by: 65a <65a@63bit.net>
Signed-off-by: 65a <65a@63bit.net>
Additional testing:
|
mudler
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good here - not merging it yet as I'd like to cut a release of the current code first as it is well tested up to now, and I prefer to keep bumps separated.
ETA for merging this is 28-29 September.
mudler
changed the title
Enable ROCm/HIPBLAS support for LocalAI
feat(llama.cpp): enable ROCm/HIPBLAS support
Sep 27, 2023
Thanks for the contribution @65a , merging it |
mudler
added a commit
to go-skynet/localai-website
that referenced
this pull request
Sep 30, 2023
mudler
added a commit
to go-skynet/localai-website
that referenced
this pull request
Oct 4, 2023
* wip: new sections Signed-off-by: mudler <mudler@localai.io> * document hipblas mudler/LocalAI#1100 * add vllm, vall-e-x, minor updates Signed-off-by: mudler <mudler@localai.io> * Add development docs: wip Signed-off-by: mudler <mudler@localai.io> --------- Signed-off-by: mudler <mudler@localai.io>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes lack of HIPBLAS support in LocalAI.
Notes for Reviewers
This PR builds on go-skynet/go-llama.cpp#235 to enable ROCm/HIPBLAS support for gguf models running under llama.cpp backend (not the stable ggml one). It can be enabled by using BUILD_TYPE=hipblas. This was tested on a gfx1100 card, but should work for gfx900,gfx1030 and other cards. Card support can be set with AMDGPU_TARGETS environment variable.
Signed commits