Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set proper Homebrew install location for x86 Macs #1510

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

cnatale
Copy link
Contributor

@cnatale cnatale commented Dec 29, 2023

Description

During my setup of Localai, I ran into problems related to the llama CMakeLists.txt not having a reference to the Homebrew install location for Intel Macs. This pr fixes the problem, while maintaining the Homebrew install location for arm64 Macs.

See https://www.reddit.com/r/MacOS/comments/jw9guu/why_did_homebrew_move_from_usrlocalto_opthomebrew/ for more info.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for localai canceled.

Name Link
🔨 Latest commit 4e16953
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/658f32355452f80008dfd9f9

Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, looks good here, thank you @cnatale !

@mudler mudler merged commit e2311a1 into mudler:master Dec 30, 2023
26 checks passed
@mudler mudler added the bug Something isn't working label Dec 30, 2023
@dave-gray101
Copy link
Collaborator

Nice fix!
I believe this may be related to some of the CI vs Local OSX problems I've been having of late - the github CI runners use "Macmini6,2" hardware as of writing this comment, which is Intel --- and all my prior testing was on an M1. I believe this could be the cause of some of the linking errors I had been seeing over the holidays, and was why I was experimenting with always rebuilding gRPC on CI for so long...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants