Update Makefile #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deletes the SYMDEF file extracted from the former archive to avoid linking implications when creating libstablediffusion.a
mudler
approved these changes
Feb 2, 2024
|
@jamu85 this actually broke again building on linux: https://github.com/mudler/LocalAI/actions/runs/7760966485/job/21168401558?pr=1674 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes the SYMDEF file extracted from the former archive to avoid linking implications when creating libstablediffusion.a
The content of libncnn.a is taken to create libstablediffusion.a. However, this results in having two __.SYMDEF files in the new archive. This is tolerated by the linker on Linux because the gnu flavor just picks the first file, the bsd linker however refuses to link if 2 SYMDEF files live in the archive.
So to fix this issue, the SYMDEF file coming from ncnn has to be deleted before the new archive gets created.
Fixes mudler/LocalAI#1443