-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog and Menu freeze delay on initial open on MeteorJS platform #29131
Comments
From the discussions on the links, it seems to me that the issue is related to SSR and how it is configured using MeteorJS. This issue is not happening with Take a look on the examples/ssr, especially on the config for the server - you need to inject the styles generated by emotion. This is a vanilla SSR example, so you should be able to easily apply it on your project. Let me know if this will help. |
@mnajdova Thanks for your response, the repo I posted in this issue, is a reproduction using MeteorJS without SSR to demonstrate the same problem. For the screenshot @alebrahimi posted, I don't know if he has a working repo without SSR that demonstrates his tests also. Let me know if you need more information. |
@simplecommerce this is the repo mateor-mui5-app this is a very simple Meteor app without SSR |
Here is a comment from MeteorJS's CEO about the issue
Hope this can help pinpoint the issue. Update Another response from the CEO after more investigation from another user to pinpoint the cause of the problem.
|
I don't believe this is a Material UI issue, instead it seems to be caused by (very) frequently updated exported variables in See thysultan/stylis#278 and benjamn/reify#277. |
I'm having the same performance issues with Meteor and MUI v5. Interesting to see that Meteor are looking into this as the issue does only seem to come up when using Meteor, so maybe there is something in what the CEO is saying. @simplecommerce where are you seeing the CEO's quotes on the subject? |
CEO said they will be working on fixing the issue in a few weeks, no updates yet. |
Just wanted to update this issue, the issue has been fixed in the latest release of Meteor 2.5.2. Details can be found here: meteor/meteor#11788 |
Current Behavior 😯
On my MeteorJS app, when I click on a button to open a Dialog or Menu, there is a freeze delay for the first time.
Any subsequent clicks to the button, will open the Dialog and Menu quickly.
If I refresh and do the same test again, the freeze delay is there.
I have tested in Edge, Chrome and Firefox and the issue is present on all of them.
In my current project, the delay can take up to 5 secs.
I do not have this issue on v4 only on v5.
I have also opened a discussion on Meteor Forums here: https://forums.meteor.com/t/material-ui-v5-dialogs-and-menus-initial-open-lags-freezes/56842/10
There was also a comment added on this issue referring to my discussion here: #21578 (comment)
Expected Behavior 🤔
The behavior should be the same as on the demo sandbox on your docs, there should be no delay when clicking to open the Dialog or Menu the first time.
Steps to Reproduce 🕹
Here is a Meteor repo reproducing the error: https://github.com/simplecommerce/mui5-meteor-simple-todo
Steps:
npm install
.meteor run
. It will run on port 3000.When running visit the app site and then click on
Open Form Dialog
orDashboard
. You will notice a small delay before it opens. Click again on those buttons and you will no longer see a delay. Hit refresh and try again and the initial open will always have a delay.I have added the demo for the Basic Modal and Transitions Modal, these are fine, they are quick on initial open every time.
So it seems to only be the Dialog and Menu so far, I have not yet tested any other components.
Your Environment 🌎
`npx @mui/envinfo`
The text was updated successfully, but these errors were encountered: