[useMediaQuery] Improve useWidth demo #16611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 2c5d99e...8dbe612 |
joshwooding
suggested changes
Jul 16, 2019
| @@ -3,21 +3,19 @@ import { ThemeProvider, useTheme } from '@material-ui/styles'; | |||
| import useMediaQuery from '@material-ui/core/useMediaQuery'; | |||
| import { createMuiTheme } from '@material-ui/core/styles'; | |||
|
|
|||
| /** | |||
| * Be careful using this hook. It only works because the number of | |||
There was a problem hiding this comment.
We use the same strategy in withWidth.js. It supports theme breakpoints customization. what's the motivation for using a different one? Should we use the same strategy everywhere?
oliviertassinari
added
docs
oliviertassinari
changed the title
joshwooding
approved these changes
Jul 18, 2019
oliviertassinari
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
@siriwatknp I went forward with the simplest possible fix. I'm still curious to hear why being explicit about all the breakpoints would be better. We could continue the discussion for another pull request. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16460